manifests: resources required for adding helm metrics in console by zonggen · Pull Request #601 · openshift/console-operator

zonggen · 2021-10-05T20:04:58Z

Adds a new ServiceMonitor to allow the Helm metrics being scraped from
console /metrics endpoint by prometheus-k8s.

Closes: https://issues.redhat.com/browse/HELM-235
Reference: #270
Signed-off-by: Allen Bai abai@redhat.com

Adds a new ServiceMonitor to allow the Helm metrics being scraped from console /metrics endpoint by prometheus-k8s. Closes: https://issues.redhat.com/browse/HELM-235 Reference: openshift#270 Signed-off-by: Allen Bai <abai@redhat.com>

zonggen · 2021-10-07T15:57:23Z

Lifted WIP as the console PR is ready and tested: openshift/console#10194

In summary, in this implementation we host a Prometheus client in the console and instructs the service monitor to scrape on console.openshift-console.svc at /metrics. For authentication, console checks for bearer token in the header and rewrites the token into a cookie and feed into the console authenticator (just like how other helm API call cookies are handled in console).

PTAL when you're available @jhadvig @spadgett @dperaza4dustbit.

dperaza4dustbit

/lgtm

jhadvig

One nit otherwise LGTM 👍
Please address the comment so we can tag the PR :)

jhadvig · 2021-10-13T10:36:40Z

+    include.release.openshift.io/self-managed-high-availability: "true"
+    include.release.openshift.io/single-node-developer: "true"
+roleRef:
+  # for protected endpoints like /metrics, the operator must perform


Suggested change

# for protected endpoints like /metrics, the operator must perform

# for protected endpoints like /metrics, the console backend must perform

Thanks for the review @jhadvig! Updated.

Signed-off-by: Allen Bai <abai@redhat.com>

zonggen · 2021-10-13T16:07:41Z

/retest

jhadvig

/lgtm
/approve

jhadvig · 2021-10-13T21:58:45Z

/retest

openshift-ci · 2021-10-13T21:59:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dperaza4dustbit, jhadvig, zonggen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-10-13T23:58:03Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-18T11:53:34Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-18T12:05:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-18T12:17:34Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-18T12:29:34Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-18T12:41:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-18T12:53:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-18T13:05:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-18T13:17:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-18T13:29:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

zonggen · 2021-10-18T13:34:32Z

It seems like this PR is dependent on the metrics PR on console side (openshift/console#10194). Once the console change is merged and new image is built, the warning alert should be resolved.

Tested with applying manifest in this PR, using default console image. As I changed to my console image with metrics change, the targetDown alert is gone:

openshift-bot · 2021-10-18T13:41:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-18T14:29:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

jhadvig · 2021-10-18T14:41:05Z

/hold

lets wait for openshift/console#10194

jhadvig · 2021-10-19T06:10:50Z

/hold for approvals
/assign @yapei @opayne1 @RickJWagner

opayne1 · 2021-10-20T17:48:23Z

/label docs-approved

yapei · 2021-10-26T07:47:34Z

/label qe-approved

RickJWagner · 2021-10-27T19:20:29Z

/label px-approved

zonggen · 2021-10-28T03:47:48Z

/unhold

zonggen · 2021-10-28T03:47:54Z

/retest

openshift-bot · 2021-10-28T05:38:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-28T08:41:09Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2021

openshift-ci Bot requested review from jhadvig and spadgett October 5, 2021 20:06

zonggen mentioned this pull request Oct 5, 2021

helm/metrics: add a new gauge metric to monitor helm releases #579

Closed

zonggen mentioned this pull request Oct 6, 2021

metrics: add /metrics endpoint and console_helm_install_count metric openshift/console#10194

Merged

zonggen changed the title ~~[WIP] manifests: resources required for adding helm metrics in console~~ manifests: resources required for adding helm metrics in console Oct 7, 2021

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2021

dperaza4dustbit approved these changes Oct 8, 2021

View reviewed changes

openshift-ci Bot assigned dperaza4dustbit Oct 8, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2021

jhadvig reviewed Oct 13, 2021

View reviewed changes

manifests: update according to reviews

594233a

Signed-off-by: Allen Bai <abai@redhat.com>

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021

jhadvig approved these changes Oct 13, 2021

View reviewed changes

openshift-ci Bot assigned jhadvig Oct 13, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2021

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2021

openshift-ci Bot assigned opayne1, RickJWagner and yapei Oct 19, 2021

openshift-ci Bot added the docs-approved Signifies that Docs has signed off on this PR label Oct 20, 2021

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Oct 26, 2021

openshift-ci Bot added the px-approved Signifies that Product Support has signed off on this PR label Oct 27, 2021

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2021

openshift-merge-robot merged commit 02ba53a into openshift:master Oct 28, 2021

	# for protected endpoints like /metrics, the operator must perform
	# for protected endpoints like /metrics, the console backend must perform

Conversation

zonggen commented Oct 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zonggen commented Oct 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dperaza4dustbit left a comment

Choose a reason for hiding this comment

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

jhadvig Oct 13, 2021

Choose a reason for hiding this comment

Uh oh!

zonggen Oct 13, 2021

Choose a reason for hiding this comment

Uh oh!

zonggen commented Oct 13, 2021

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

jhadvig commented Oct 13, 2021

Uh oh!

openshift-ci Bot commented Oct 13, 2021

Uh oh!

openshift-bot commented Oct 13, 2021

Uh oh!

openshift-bot commented Oct 18, 2021

Uh oh!

openshift-bot commented Oct 18, 2021

Uh oh!

openshift-bot commented Oct 18, 2021

Uh oh!

openshift-bot commented Oct 18, 2021

Uh oh!

openshift-bot commented Oct 18, 2021

Uh oh!

openshift-bot commented Oct 18, 2021

Uh oh!

openshift-bot commented Oct 18, 2021

Uh oh!

openshift-bot commented Oct 18, 2021

Uh oh!

openshift-bot commented Oct 18, 2021

Uh oh!

zonggen commented Oct 18, 2021

Uh oh!

openshift-bot commented Oct 18, 2021

Uh oh!

openshift-bot commented Oct 18, 2021

Uh oh!

jhadvig commented Oct 18, 2021

Uh oh!

jhadvig commented Oct 19, 2021

Uh oh!

opayne1 commented Oct 20, 2021

Uh oh!

yapei commented Oct 26, 2021

Uh oh!

RickJWagner commented Oct 27, 2021

Uh oh!

zonggen commented Oct 28, 2021

Uh oh!

zonggen commented Oct 28, 2021

Uh oh!

openshift-bot commented Oct 28, 2021

Uh oh!

openshift-bot commented Oct 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

zonggen commented Oct 5, 2021 •

edited

Loading

zonggen commented Oct 7, 2021 •

edited

Loading